Bug 53845

Summary:

Add performance tests for URL parsing

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	abarth: review+

Description Eric Seidel (no email) 2011-02-05 02:54:56 PST

Add performance tests for URL parsing

Comment 1 Eric Seidel (no email) 2011-02-05 03:08:53 PST

I'm omitting the urls file from the uploaded patch since it's too big. :(

Comment 2 Eric Seidel (no email) 2011-02-05 03:10:14 PST

Created attachment 81352 [details]
Patch

Comment 3 Eric Seidel (no email) 2011-02-05 03:13:50 PST

Committed r77739: <http://trac.webkit.org/changeset/77739>

Comment 4 Eric Seidel (no email) 2011-02-05 03:22:36 PST

Some figures:

We call KURL::parse() about 2000 times when loading gmail.com (a logged in account).

Since our benchmark parses apple.com 200000 times in under 400ms, it seems URL parsing is not a huge perf concern at the moment.

Comment 5 Eric Seidel (no email) 2011-02-05 03:23:49 PST

Based on those numbers, we're spending about 4ms in URL parsing while loading gmail (that's a very rough estimate).

Comment 6 Eric Seidel (no email) 2011-02-05 03:25:07 PST

Or using the figures from the english url corpus, a rough estimate of time spent loading gmail parsing urls would be 6.5 ms.  In either case, these are not huge numbers.