Bug 53808
| Summary: | GCC compiler on ARM compile fix has issues. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Levin <levin> |
| Component: | WebKit Misc. | Assignee: | Dimitri Glazkov (Google) <dglazkov> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | abarth, darin, eric, levin |
| Priority: | P1 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Other | ||
| OS: | Other | ||
| Bug Depends on: | 53620 | ||
| Bug Blocks: | |||
David Levin
1. The define isn't specific enough.
2. The code is stuck forever. How will we know when it can be removed?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
You're a good man, señior levin. But I wouldn't kill yourself over this fix.
I look forward to the review!
Dimitri Glazkov (Google)
(In reply to comment #0)
> 1. The define isn't specific enough.
I can tighten up the define using GCC_VERSION_AT_LEAST.
> 2. The code is stuck forever. How will we know when it can be removed?
I scoured gcc.gnu.org/bugzilla. Nothing sticks out. It also appears our cross-compiler on the ARM bot is quite old, so we should update it and see if it's gone away.
David Levin
I think the gcc arm compiler has been upgraded (during abarth's stint as gardener) and likely gotten rid of this issue.
Perhaps it is time to remove the code added in 53620.
David Levin
This compiler fix appears to have been removed as part of http://trac.webkit.org/changeset/80463 so the issue is fixed now.