Bug 53805

Summary: WebKit2 on Windows should use DrawingAreaProxyImpl
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Layout and RenderingAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Bug Depends on: 53875, 53878, 53879, 54123, 54141, 54142, 54145    
Bug Blocks: 45567, 53877    
Attachments:
Description Flags
Make it possible to use DrawingAreaProxyImpl on Windows
none
Turn on the new drawing area on Windows darin: review+

Adam Roben (:aroben)
Reported 2011-02-04 13:10:31 PST
Now that WebKit2 on Mac has switched over to DrawingAreaProxyImpl, we should switch on Windows, too. Anders says we need to: 1) Implement BackingStoreWin - should be simple, probably just need a DIB or something 2) change the implementation of PageClient::createDrawingAreaProxy to return a new DrawingAreaProxyImpl 3) remove a bunch of #if !PLATFORM(MAC) #error directives 4) Change WebView::onPaintEvent/WebView::onPrintClientEvent to paint the way -[WKView drawRect:] does
Attachments
Make it possible to use DrawingAreaProxyImpl on Windows (10.82 KB, patch)
2011-02-06 08:56 PST, Adam Roben (:aroben)
no flags
Turn on the new drawing area on Windows (1.57 KB, patch)
2011-02-09 14:36 PST, Adam Roben (:aroben)
darin: review+
Adam Roben (:aroben)
Comment 1 2011-02-04 13:11:01 PST
Adam Roben (:aroben)
Comment 2 2011-02-06 08:56:28 PST
Created attachment 81410 [details] Make it possible to use DrawingAreaProxyImpl on Windows
Adam Roben (:aroben)
Comment 3 2011-02-06 09:00:09 PST
Comment on attachment 81410 [details] Make it possible to use DrawingAreaProxyImpl on Windows Whoops, wrong bug!
Adam Roben (:aroben)
Comment 4 2011-02-07 13:21:19 PST
Adam Roben (:aroben)
Comment 5 2011-02-07 13:21:52 PST
(In reply to comment #4) > Committed r77839: <http://trac.webkit.org/changeset/77839> Whoops, wrong bug!
Adam Roben (:aroben)
Comment 6 2011-02-09 14:36:25 PST
Created attachment 81877 [details] Turn on the new drawing area on Windows
Adam Roben (:aroben)
Comment 7 2011-02-10 04:43:40 PST
Note You need to log in before you can comment on or make changes to this bug.