Summary: | Assertion failure in WebInspectorProxy::platformClose closing main window when inspecting a popup window, or when running regression tests | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brian Weinstein <bweinstein> | ||||
Component: | WebKit2 | Assignee: | Brian Weinstein <bweinstein> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aroben | ||||
Priority: | P2 | Keywords: | InRadar, PlatformOnly | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows 7 | ||||||
Attachments: |
|
Description
Brian Weinstein
2011-02-04 12:22:31 PST
Created attachment 81264 [details]
[PATCH] Fix
Comment on attachment 81264 [details] [PATCH] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=81264&action=review > Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:178 > + if (m_isVisible) { > + ASSERT(m_inspectorWindow); > + ASSERT(m_inspectorView); > + } To get rid of the if in Release builds, you could do: ASSERT(!m_isVisible || m_inspectorWindow); ASSERT(!m_isVisible || m_inspectorView); > Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:181 > + ASSERT(::IsWindow(m_inspectorWindow)); Have you verified that this is true even when the inspector is docked? (In reply to comment #2) > (From update of attachment 81264 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=81264&action=review > > > Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:178 > > + if (m_isVisible) { > > + ASSERT(m_inspectorWindow); > > + ASSERT(m_inspectorView); > > + } > > To get rid of the if in Release builds, you could do: > > ASSERT(!m_isVisible || m_inspectorWindow); > ASSERT(!m_isVisible || m_inspectorView); Fixed. > > > Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:181 > > + ASSERT(::IsWindow(m_inspectorWindow)); > > Have you verified that this is true even when the inspector is docked? We don't support a docked inspector in WebKit2 yet, but I will make sure to check this when we do. Thanks! |