Bug 53755
| Summary: | check-webkit-style complains about the occurrence of "NULL" in comments | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Cosmin Truta <ctruta> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | levin |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Cosmin Truta
When preparing the fix for bug 53749, I noticed that check-webkit-style complains about the occurrence of "NULL", although this word is used (appropriately IMO) in a comment only.
Is this behavior intentional, or is it a bug?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Levin
Intentional behavior and specifically coded this way in fact.
The reasoning has been that NULL is not allowed in code so it doesn't make sense in comments. For example, in bug 53749, the comment says that a parameter may be NULL. That really isn't true because if code were to pass in NULL, it would be a style error. The parameter may be 0 in fact.