Bug 53745

Summary: Remove unneeded function declarations in comments in EditorClient.h
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Trivial CC: darin, ggaren, leviw
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://trac.webkit.org/browser/trunk/Source/WebCore/page/EditorClient.h?annotate=blame&rev=75523#L122
Attachments:
Description Flags
Patch darin: review+

Levi Weintraub
Reported 2011-02-03 17:48:37 PST
EditorClient.h contains 5 functions that were commented out over 4 years ago, and three of which reference NS_____ objects. Unless anyone objects I'll clean them up. They don't appear to have references in WebKit at all. CC-ing from svn blame.
Attachments
Patch (1.86 KB, patch)
2011-02-04 11:26 PST, Levi Weintraub 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2011-02-04 09:44:44 PST
It’s fine to remove these functions. It’s not quite right to say they were “commented out 4 years ago”. They have always been commented out! See <http://trac.webkit.org/browser/trunk/WebCore/bridge/EditorClient.h?rev=17179> for the initial version of the file.
Levi Weintraub
Comment 2 2011-02-04 11:26:50 PST
Created attachment 81252 [details] Patch
Levi Weintraub
Comment 3 2011-02-04 11:58:02 PST
Committed r77651: <http://trac.webkit.org/changeset/77651>
Note You need to log in before you can comment on or make changes to this bug.