| Summary: | [v8] Bail out if to string conversion returned empty handle | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | anton muhin <antonm> | ||||||
| Component: | WebKit Misc. | Assignee: | anton muhin <antonm> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
anton muhin
2011-02-03 09:33:26 PST
Created attachment 81071 [details]
Patch
Comment on attachment 81071 [details]
Patch
Generally speaking, we'd rather fix the root cause of the issue that bandaid over it like this. Maybe add an ASSERT_NOT_REACHED to emphasize that it shouldn't happen? Ideally we'd remove this code once we fixed the underlying bug...
Created attachment 81076 [details]
Patch
(In reply to comment #2) > (From update of attachment 81071 [details]) > Generally speaking, we'd rather fix the root cause of the issue that bandaid over it like this. Maybe add an ASSERT_NOT_REACHED to emphasize that it shouldn't happen? Ideally we'd remove this code once we fixed the underlying bug... Definitely. I've got something which looks pretty much like a reduction for the core problem, but it's pure v8 API test. I am starting to work on it immediately. When issue in v8 is fixed, we'll run automated test with v8 patch applied and this patch removed. If things go smooth, I'll revert this patch. And ASSERT added Comment on attachment 81076 [details]
Patch
Thank you again, Adam.
Comment on attachment 81076 [details] Patch Clearing flags on attachment: 81076 Committed r77597: <http://trac.webkit.org/changeset/77597> All reviewed patches have been landed. Closing bug. |