Bug 53676

Summary:

fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code tests fail when showModalDialog isn't supported

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED CONFIGURATION CHANGED

Severity:

Normal

CC:

ahmad.saleem792, ap, barraclough, ggaren, leandro, oliver, rakuco, sam, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
fix patch	none

Adam Roben (:aroben)

Reported 2011-02-03 06:06:42 PST

To reproduce: 1. Delete the -webViewRunModal: implementation from DumpRenderTree/mac/UIDelegate.mm 2. run-webkit-tests fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code All the tests fail. They seem to be failing because "this.showModalDialog" exists in the eval scope but not in the non-eval scope. Why would eval() cause showModalDialog to appear?

Attachments
fix patch (7.99 KB, patch) 2011-06-20 12:04 PDT, Chang Shu	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2011-02-03 06:07:31 PST

Until bug 53675 is fixed, this bug is causing these tests to fail on Windows. They were added to the Skipped file way back in r61599.

Adam Roben (:aroben)

Comment 2 2011-02-03 06:36:59 PST

<rdar://problem/8953560>

Chang Shu

Comment 3 2011-06-20 12:04:38 PDT

Created attachment 97835 [details] fix patch It seems to me all I have to do is to hook up the runModal function.

WebKit Review Bot

Comment 4 2011-06-20 12:25:59 PDT

Comment on attachment 97835 [details] fix patch Clearing flags on attachment: 97835 Committed r89270: <http://trac.webkit.org/changeset/89270>

WebKit Review Bot

Comment 5 2011-06-20 12:26:04 PDT

All reviewed patches have been landed. Closing bug.

Adam Roben (:aroben)

Comment 6 2011-06-20 22:20:13 PDT

This bug was not meant to be about the WK2-specific failures on these tests. This bug is about the fact that these tests are affected by whether the showModalDialog function exists or not. A new bug should have been filed to cover the WK2-specific failures.

Chang Shu

Comment 7 2011-06-21 06:37:12 PDT

(In reply to comment #6) > This bug was not meant to be about the WK2-specific failures on these tests. This bug is about the fact that these tests are affected by whether the showModalDialog function exists or not. A new bug should have been filed to cover the WK2-specific failures. Right. :) Sorry for the confusion.

Ahmad Saleem

Comment 8 2023-12-19 16:42:45 PST

Tests are gone with 'https://github.com/WebKit/WebKit/commit/011fe7359898b678e31fabdc17df1ff69b910764'. Marking this as 'RESOLVED CONFIGURATION CHANGED'.

Note You need to log in before you can comment on or make changes to this bug.