Bug 53674

Summary:

[Qt]REGRESSION(r76951): media/controls-without-preload.html fails

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Major

CC:

dglazkov, tkent

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

53122, 53314

Attachments:

Description	Flags
fail - png	none
Patch	none

Description Csaba Osztrogonác 2011-02-03 05:23:11 PST

http://trac.webkit.org/changeset/76951 broke media/controls-without-preload.html

Comment 1 Csaba Osztrogonác 2011-02-03 05:34:23 PST

--- a/LayoutTests/platform/qt/media/controls-without-preload-expected.txt
+++ b/LayoutTests/platform/qt/media/controls-without-preload-expected.txt
@@ -14,13 +14,13 @@ layer at (8,45) size 300x150
   RenderBlock (relative positioned) {DIV} at (0,0) size 300x150
 layer at (8,45) size 300x150
   RenderFlexibleBox (positioned) {DIV} at (0,0) size 300x150
-    RenderButton {INPUT} at (5,121) size 32x24
-    RenderFlexibleBox {DIV} at (40,116) size 228x34
+    RenderButton {INPUT} at (5,133) size 23x12
+    RenderFlexibleBox {DIV} at (31,116) size 249x34
       RenderBlock (anonymous) at (0,0) size 81x34
-      RenderSlider {INPUT} at (84,5) size 141x24
-        RenderBlock {DIV} at (8,6) size 4x12
-    RenderButton {INPUT} at (271,121) size 24x24
-layer at (51,166) size 75x24 scrollHeight 25
+      RenderSlider {INPUT} at (84,11) size 162x12
+        RenderBlock {DIV} at (8,0) size 4x12
+    RenderButton {INPUT} at (283,133) size 12x12
+layer at (42,166) size 75x24 scrollHeight 25
   RenderBlock {DIV} at (3,5) size 75x24 [color=#FFFFFF]
     RenderText {#text} at (6,6) size 63x13
       text run at (6,6) width 63: "00:00 / 00:00"

expected png: http://trac.webkit.org/browser/trunk/LayoutTests/platform/qt/media/controls-without-preload-expected.png
actual png: <attached>

Comment 2 Csaba Osztrogonác 2011-02-03 05:36:20 PST

Created attachment 81053 [details]
fail - png

Comment 3 Csaba Osztrogonác 2011-02-03 05:38:31 PST

Any idea, why is it broken?

Comment 4 Csaba Osztrogonác 2011-02-03 05:44:32 PST

I added it to the Skipped list until fix: http://trac.webkit.org/changeset/77479

Comment 5 Dimitri Glazkov (Google) 2011-02-03 09:06:43 PST

I am working on it.

*** This bug has been marked as a duplicate of bug 53314 ***

Comment 6 Dimitri Glazkov (Google) 2011-02-03 09:07:52 PST

Oops. Duping wasn't right. Thanks for creating a separate bug.

Comment 7 Dimitri Glazkov (Google) 2011-02-04 13:29:19 PST

Created attachment 81276 [details]
Patch

Comment 8 Csaba Osztrogonác 2011-02-04 13:39:27 PST

Comment on attachment 81276 [details]
Patch

Thanks for fixing it, r=me.

Comment 9 Dimitri Glazkov (Google) 2011-02-04 13:43:31 PST

Comment on attachment 81276 [details]
Patch

Clearing flags on attachment: 81276

Committed r77669: <http://trac.webkit.org/changeset/77669>

Comment 10 Dimitri Glazkov (Google) 2011-02-04 13:43:34 PST

All reviewed patches have been landed.  Closing bug.