| Summary: | [Qt] WebKit2 needs to support font size changing and getting default font size | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Juha Savolainen <juha.savolainen> | ||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, commit-queue, eric, kenneth, kling, webkit.review.bot | ||||
| Priority: | P2 | Keywords: | Qt, QtTriaged | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Juha Savolainen
2011-02-03 04:18:12 PST
Created attachment 81050 [details]
Added fontSize enum and methods to get/set default font sizes.
Any reason we can't have the exact same API as WK1 QWebSettings setFontSize/fontSize? (In reply to comment #2) > Any reason we can't have the exact same API as WK1 QWebSettings setFontSize/fontSize? Do you mean missing enum QWebSettings::MinimumLogicalFontSize? If yes, I didnt find any C-function for this and in WK1 there is the following description: The minimum logical font size that is applied when zooming out with QWebFrame::setTextSizeMultiplier(). And in WK2 we don't have frame API so that was the reason. But if I have understand something wrong or you have noticed something else, please correct me. Andreas, could you clarify this a little? (In reply to comment #4) > Andreas, could you clarify this a little? Sorry, I completely forgot about this patch. It's fine as-is, r=me :) Comment on attachment 81050 [details] Added fontSize enum and methods to get/set default font sizes. Clearing flags on attachment: 81050 Committed r79997: <http://trac.webkit.org/changeset/79997> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/79997 might have broken GTK Linux 32-bit Debug |