Bug 53671

Summary:

[Qt] WebKit2 needs to support font size changing and getting default font size

Product:

WebKit

Reporter:

Juha Savolainen <juha.savolainen>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, eric, kenneth, kling, webkit.review.bot

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Added fontSize enum and methods to get/set default font sizes.	none

Juha Savolainen

Reported 2011-02-03 04:18:12 PST

QWKPreferences should support setting/getting default font sizes.

Attachments
Added fontSize enum and methods to get/set default font sizes. (2.84 KB, patch) 2011-02-03 04:25 PST, Juha Savolainen	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Juha Savolainen

Comment 1 2011-02-03 04:25:59 PST

Created attachment 81050 [details] Added fontSize enum and methods to get/set default font sizes.

Andreas Kling

Comment 2 2011-02-03 05:51:13 PST

Any reason we can't have the exact same API as WK1 QWebSettings setFontSize/fontSize?

Juha Savolainen

Comment 3 2011-02-03 09:26:14 PST

(In reply to comment #2) > Any reason we can't have the exact same API as WK1 QWebSettings setFontSize/fontSize? Do you mean missing enum QWebSettings::MinimumLogicalFontSize? If yes, I didnt find any C-function for this and in WK1 there is the following description: The minimum logical font size that is applied when zooming out with QWebFrame::setTextSizeMultiplier(). And in WK2 we don't have frame API so that was the reason. But if I have understand something wrong or you have noticed something else, please correct me.

Juha Savolainen

Comment 4 2011-03-01 03:46:27 PST

Andreas, could you clarify this a little?

Andreas Kling

Comment 5 2011-03-01 04:22:44 PST

(In reply to comment #4) > Andreas, could you clarify this a little? Sorry, I completely forgot about this patch. It's fine as-is, r=me :)

WebKit Commit Bot

Comment 6 2011-03-01 06:13:19 PST

Comment on attachment 81050 [details] Added fontSize enum and methods to get/set default font sizes. Clearing flags on attachment: 81050 Committed r79997: <http://trac.webkit.org/changeset/79997>

WebKit Commit Bot

Comment 7 2011-03-01 06:13:24 PST

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 8 2011-03-01 08:39:34 PST

http://trac.webkit.org/changeset/79997 might have broken GTK Linux 32-bit Debug

Note You need to log in before you can comment on or make changes to this bug.