Summary: | [GTK] Need support for dumping focus rectangles in pixel results | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | zan | ||||
Priority: | P3 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Martin Robinson
2011-02-02 17:02:28 PST
This test successfully passes with a release 64-bit build at revision 82691. Also the focus rectangle seems to be properly shown when running pixel tests. Are there any issues with this test in debug builds or should we try unskipping it? (In reply to comment #1) > This test successfully passes with a release 64-bit build at revision 82691. Also the focus rectangle seems to be properly shown when running pixel tests. > > Are there any issues with this test in debug builds or should we try unskipping it? I think it's still missing the red rectangle. Compare the results: a. LayoutTests/platform/gtk/editing/selection/transformed-selection-rects-expected.png b. LayoutTests/platform/mac/editing/selection/transformed-selection-rects-expected.png b. LayoutTests/platform/chromium-win/editing/selection/transformed-selection-rects-expected.png Created attachment 89923 [details]
Patch
(In reply to comment #3) > Created an attachment (id=89923) [details] > Patch This patch adds support for dumping selection rectangle. The pixel results for editing/selection/transformed-selection-rects.html now have a proper red rectangle around the area of the selection. Grepping through the LayoutTests directory, these tests seem to utilize this functionality and should have their expected pixel results regenerated: editing/selection/4402375.html editing/selection/image-before-linebreak.html editing/selection/replaced-boundaries-1.html editing/selection/replaced-boundaries-2.html editing/selection/replaced-boundaries-3.html editing/selection/transformed-selection-rects.html svg/text/foreignObject-text-clipping-bug.xml svg/text/selection-doubleclick.svg svg/text/selection-tripleclick.svg svg/text/text-align-01-b.svg svg/text/text-align-02-b.svg svg/text/text-align-03-b.svg svg/text/text-align-04-b.svg svg/text/text-align-05-b.svg svg/text/text-align-06-b.svg svg/text/text-altglyph-01-b.svg svg/text/text-deco-01-b.svg svg/text/text-fonts-01-t.svg svg/text/text-fonts-02-t.svg svg/text/text-intro-05-t.svg svg/text/text-path-01-b.svg svg/text/text-spacing-01-b.svg svg/text/text-text-01-b.svg svg/text/text-text-03-b.svg svg/text/text-text-04-t.svg svg/text/text-text-05-t.svg svg/text/text-text-06-t.svg svg/text/text-text-07-t.svg svg/text/text-text-08-b.svg svg/text/text-tref-01-b.svg svg/text/text-tselect-01-b.svg svg/text/text-tselect-02-f.svg svg/text/text-tspan-01-b.svg svg/text/text-ws-01-t.svg svg/text/text-ws-02-t.svg svg/text/textPathBoundsBug.svg Comment on attachment 89923 [details]
Patch
Great. I will land this and generate the results.
Committed r84221: <http://trac.webkit.org/changeset/84221> |