Bug 53633

Summary: gl-teximage.html failing on some WebKit bots
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, eric, jamesr, mihaip, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Attachments:
Description Flags
Patch mihaip: review+

Kenneth Russell
Reported 2011-02-02 15:34:01 PST
The layout test fast/canvas/webgl/gl-teximage.html, in particular the indexed PNG test added in https://bugs.webkit.org/show_bug.cgi?id=47477 , is failing on some WebKit bots. The issue appears to be that the color profile of the display is affecting the color of the PNG uploaded to WebGL. Mihai points out that when DRT runs pixel tests (see in particular Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm, setupMainDisplayColorProfile) it loads a specific color profile for consistency of the results. This isn't occurring when running the WebGL layout tests. This test loads and tests several other PNGs without trouble. I suspect that by stripping gamma and other colorspace information from this particular PNG that we can get consistent enough results without changing DRT to load a particular color profile even when not running pixel tests.
Attachments
Patch (2.47 KB, patch)
2011-02-02 15:38 PST, Kenneth Russell 		mihaip: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2011-02-02 15:38:45 PST
Created attachment 80982 [details] Patch
Kenneth Russell
Comment 2 2011-02-02 19:02:00 PST
Committed r77458: <http://trac.webkit.org/changeset/77458>
Note You need to log in before you can comment on or make changes to this bug.