Bug 53614

Summary: Remove physical terminology from overflow.
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
hyatt: review-
Patch mitz: review+

Dave Hyatt
Reported 2011-02-02 12:01:36 PST
Don't use top/right/bottom/left to describe overflow that is in the block's local coordinate space (which could be flipped). Use minX/maxX/minY/maxY instead.
Attachments
Patch (41.21 KB, patch)
2011-02-02 12:02 PST, Dave Hyatt 		hyatt: review-
DetailsFormatted DiffDiff
Patch (37.93 KB, patch)
2011-02-02 12:11 PST, Dave Hyatt 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2011-02-02 12:02:52 PST
Created attachment 80943 [details] Patch
Dave Hyatt
Comment 2 2011-02-02 12:11:00 PST
Created attachment 80948 [details] Patch
WebKit Review Bot
Comment 3 2011-02-02 12:14:11 PST
Attachment 80943 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7686882
Dave Hyatt
Comment 4 2011-02-02 12:19:38 PST
Fixed in r77397.
WebKit Review Bot
Comment 5 2011-02-02 12:21:05 PST
Attachment 80948 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7690160
Note You need to log in before you can comment on or make changes to this bug.