Bug 53608 – Enable media tests in chromium-gpu/test_expectations

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Victoria Kirst]

The media tests also trigger the GPU-accelerated compositing path, so media tests should be enabled.

[Victoria Kirst]

Created attachment 80939 [details]
Patch

[Dirk Pranke]

Looks fine to me, but I'm not a reviewer ...

[Mihai Parparita]

Comment on attachment 80939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80939&action=review

> LayoutTests/platform/chromium-gpu/test_expectations.txt:294
> +BUGWK53609 SKIP : media/controls-after-reload.html = IMAGE

These shouldn't be skipped, we'd still like to run them so that if they fail for another reason (e.g. text diff instead of image diff, or timeout) we'll know.

[Dirk Pranke]

This still needs to happen. Taking ownership.

[Victoria Kirst]

OK, figured out how to get DRT+Mesa working with media layout tests! It is the same problem as issue 54694. It has also unveiled other media bugs in rendering... The bugs are minor, so I'm not sure if I should wait to enable media/ until after the media bugs are fixed (for accurate expected results) or enable the tests then rebaseline? In any case..

dpranke: Can you assign this to me?

[Dirk Pranke]

sure, happy to. Feel free to steal bugs from me, too :)

[Victoria Kirst]

*** Bug 55540 has been marked as a duplicate of this bug. ***

[Victoria Kirst]

Created attachment 84346 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 84346 [details]
Patch

Rejecting attachment 84346 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 2

Last 500 characters of output:

Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/chromium/test_expectations.txt
Hunk #1 FAILED at 3008.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Carlson', u'--for..." exit_code: 1

Full output: http://queues.webkit.org/results/8083261

[Mihai Parparita]

I'll land this, since test_expectations.txt changes often enough that it can be hard to patch it via the commit queue.

[Mihai Parparita]

Committed r80257: <http://trac.webkit.org/changeset/80257>