Bug 53606

Summary: Web Inspector: [Chromium] Landing detailed heap snapshots, part 2
Product: WebKit Reporter: Mikhail Naganov <mnaganov>
Component: Web Inspector (Deprecated)Assignee: Mikhail Naganov <mnaganov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 50510    
Attachments:
Description Flags
patch pfeldman: review+, mnaganov: commit-queue-

Description Mikhail Naganov 2011-02-02 10:36:10 PST
Next part: displaying progress while taking a snapshot, and hints while loading and parsing. This is needed because taking detailed heap snapshots takes time.
Comment 1 Mikhail Naganov 2011-02-02 10:39:51 PST
Created attachment 80931 [details]
patch
Comment 2 Pavel Feldman 2011-02-02 10:47:20 PST
Comment on attachment 80931 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80931&action=review

> Source/WebCore/inspector/front-end/ProfilesPanel.js:451
> +        function doParse() {

{ on the next line.
Comment 3 Mikhail Naganov 2011-02-02 10:51:00 PST
Comment on attachment 80931 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80931&action=review

>> Source/WebCore/inspector/front-end/ProfilesPanel.js:451
>> +        function doParse() {
> 
> { on the next line.

Fixed.
Comment 4 Mikhail Naganov 2011-02-02 10:57:26 PST
Manually committed http://trac.webkit.org/changeset/77387

2011-02-02  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Landing detailed heap snapshots, part 2.

        https://bugs.webkit.org/show_bug.cgi?id=53606

        Display progress while taking a snapshot, and hints while loading
        and parsing. This is needed because taking detailed heap snapshots
        takes time.

        * English.lproj/localizedStrings.js:
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.DetailedHeapshotProfileType.prototype.buttonClicked):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype._reset):
        (WebInspector.ProfilesPanel.prototype._addProfileHeader):
        (WebInspector.ProfilesPanel.prototype.getProfiles):
        (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
        (WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
        (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
        * inspector/front-end/SidebarTreeElement.js:
        (WebInspector.SidebarTreeElement.prototype.refreshTitles):