Bug 53605

Summary: [GTK] The GTK+ DRT needs an implementation of the PlainTextController
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, mrobinson, xan.lopez
Priority: P3 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Description Martin Robinson 2011-02-02 10:31:49 PST 
There is no implementation of the PlainTextController for the GTK+ DRT, thus we fail editing/text-iterator/basic-iteration.html.
Comment 1 Martin Robinson 2011-02-03 12:30:55 PST 
Created attachment 81098 [details]
Patch
Comment 2 Martin Robinson 2011-02-03 12:31:17 PST 
I've attached an implementation of this controller.
Comment 3 Eric Seidel (no email) 2011-04-06 10:25:07 PDT 
Comment on attachment 81098 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81098&action=review

Seems sane.  It's not clear why this code can't be better shared between ports.

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:765
> +static void addControllerToWindow(JSContextRef context, JSObjectRef windowObject, const char* controllerName, JSValueRef controller)

Yay!
Comment 4 Martin Robinson 2011-04-11 16:25:23 PDT 
Committed r83530: <http://trac.webkit.org/changeset/83530>