Bug 53595

Summary:

Device element patch 0: adding compilation guards to conditionally compile all future related patches.

Product:

WebKit

Reporter:

Leandro Graciá Gil <leandrogracia>

Component:

WebCore Misc.

Assignee:

Leandro Graciá Gil <leandrogracia>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

abarth, adam.bergkvist, anand.1.patil, andreip, jorlow, laszlo.gombos, leandrogracia, luiz

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

Bug Blocks:

43572, 53776

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Leandro Graciá Gil

Reported 2011-02-02 07:55:00 PST

This patch does not introduce any code, but prepares the ground for the next ones. This should be required independently of the approach taken later to implement the device tag.

Attachments
Patch (25.60 KB, patch) 2011-02-02 08:26 PST, Leandro Graciá Gil	no flags	Details Formatted Diff Diff
Patch (26.99 KB, patch) 2011-02-04 09:49 PST, Leandro Graciá Gil	no flags	Details Formatted Diff Diff
Patch (27.01 KB, patch) 2011-02-10 06:18 PST, Leandro Graciá Gil	no flags	Details Formatted Diff Diff
Patch (27.97 KB, patch) 2011-03-08 11:52 PST, Leandro Graciá Gil	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Leandro Graciá Gil

Comment 1 2011-02-02 08:26:37 PST

Created attachment 80914 [details] Patch

Leandro Graciá Gil

Comment 2 2011-02-02 08:27:55 PST

The bug https://bugs.webkit.org/show_bug.cgi?id=40878 was used as template for this patch.

Leandro Graciá Gil

Comment 3 2011-02-04 09:49:41 PST

Created attachment 81236 [details] Patch

Leandro Graciá Gil

Comment 4 2011-02-04 09:50:14 PST

Added missing features.pri file.

Eric Seidel (no email)

Comment 5 2011-02-07 15:20:46 PST

Comment on attachment 81236 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81236&action=review This patch seems OK. I'm not sure what the current thinking on the device element is. > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) This will cause the cq to fail.

Andrei Popescu

Comment 6 2011-02-07 15:47:58 PST

(In reply to comment #5) > (From update of attachment 81236 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=81236&action=review > > This patch seems OK. I'm not sure what the current thinking on the device element is. > There is an early draft spec at: http://www.whatwg.org/specs/web-apps/current-work/complete/commands.html#devices As far as I understand, this draft needs implementation feedback at this point. > > Source/WebCore/ChangeLog:8 > > + No new tests. (OOPS!) > > This will cause the cq to fail.

Leandro Graciá Gil

Comment 7 2011-02-10 06:18:04 PST

Created attachment 81969 [details] Patch

Leandro Graciá Gil

Comment 8 2011-02-10 06:19:41 PST

(In reply to comment #5) > (From update of attachment 81236 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=81236&action=review > > This patch seems OK. I'm not sure what the current thinking on the device element is. > > > Source/WebCore/ChangeLog:8 > > + No new tests. (OOPS!) > > This will cause the cq to fail. Fixed.

Leandro Graciá Gil

Comment 9 2011-03-08 11:52:04 PST

Created attachment 85070 [details] Patch

Leandro Graciá Gil

Comment 10 2011-03-08 11:56:44 PST

Patch rebased. Adding guard settings to DerivedSources.make.

Eric Seidel (no email)

Comment 11 2011-04-18 09:12:14 PDT

Comment on attachment 85070 [details] Patch Cleared review? from attachment 85070 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).

Note You need to log in before you can comment on or make changes to this bug.