Bug 53561

Summary:

Stepping through print previews in WebKit2 mode steps in and out of printing mode a lot

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Printing

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

sam

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.6

Attachments:

Description	Flags
proposed patch	sam: review+

Description Alexey Proskuryakov 2011-02-01 17:40:27 PST

This makes performance of stepping through print preview really bad on documents with many pages, such as <http://www.whatwg.org/specs/web-apps/current-work/>

<rdar://problem/8900228>

Comment 1 Alexey Proskuryakov 2011-02-01 17:47:39 PST

Created attachment 80862 [details]
proposed patch

Comment 2 Sam Weinig 2011-02-01 18:35:18 PST

Comment on attachment 80862 [details]
proposed patch

I think this would be cleaner if we added beginPrinting() endPrinting() calls to PageClient, and do the autodisplay() calls in the mac implementation of them.  What do you think?

Comment 3 Alexey Proskuryakov 2011-02-02 10:20:58 PST

I don't like beginPrinting/endPrinting - we already have methods with these names, and they do different things, being called at a different time.

It might be better to just get a WKView (or NSWindow) pointer somehow, and have this code inside WKPrintingView, not in a page client. Not sure how to best do that, will land as is for now.

Comment 4 Alexey Proskuryakov 2011-02-02 10:52:17 PST

Committed <http://trac.webkit.org/changeset/77386>.