Bug 53549

Summary: Remove useless comment
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 53474    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2011-02-01 16:21:25 PST
Remove useless comment
Attachments
Patch (1.35 KB, patch)
2011-02-01 16:31 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-02-01 16:31:45 PST
Created attachment 80851 [details] Patch
Andreas Kling
Comment 2 2011-02-01 16:37:25 PST
Comment on attachment 80851 [details] Patch Quite useless indeed.
WebKit Commit Bot
Comment 3 2011-02-01 21:13:52 PST
Comment on attachment 80851 [details] Patch Clearing flags on attachment: 80851 Committed r77361: <http://trac.webkit.org/changeset/77361>
WebKit Commit Bot
Comment 4 2011-02-01 21:13:57 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 5 2011-02-01 21:37:17 PST
Actually, I found this comment extremely useful when working on this code.
Adam Barth
Comment 6 2011-02-01 21:46:14 PST
(In reply to comment #5) > Actually, I found this comment extremely useful when working on this code. I can't tell whether you're kidding. Maybe we should change the true/false to be an enum? (I couldn't have been the "no clue why" part that was useful, right?)
Alexey Proskuryakov
Comment 7 2011-02-01 21:58:05 PST
Yes, this was essentially a FIXME comment. The fact that this generic code somehow special cased a certain kind of plug-ins was worth drawing special attention for me when I looked at this function, and I was glad that Eric (I think) has added it.
Note You need to log in before you can comment on or make changes to this bug.