Summary: | Send messages when entering/exiting accelerated compositing | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Anders Carlsson
2011-02-01 14:21:09 PST
Created attachment 80828 [details]
Patch
Attachment 80828 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/Shared/LayerTreeContext.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 80828 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80828&action=review > Source/WebKit2/Shared/LayerTreeContext.h:50 > +#if PLATFORM(MAC) > + uint32_t contextID; > +#endif A public data member on a class? Eww! > Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.h:54 > + RetainPtr<WKCARemoteLayerClientRef> m_remoteLayerRef; Why "Ref"? How about m_remoteLayerClient? > Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm:36 > +#import <WebKitSystemInterface.h> Missing a WebKitSystemInterface/ > Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm:56 > + // FIXME: Create a real layer. > + CALayer *layer = [CALayer layer]; Huh? How is this an unreal layer? Committed r77315: <http://trac.webkit.org/changeset/77315> |