Bug 53493

Summary: DevTools: assertion failure upon devtools window reopen.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Vivek Galatage <vivekgalatage>
Status: RESOLVED FIXED    
Severity: Normal CC: vivekgalatage, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Pavel Feldman
Reported 2011-02-01 08:02:15 PST
Patch to follow.
Attachments
Patch (1.39 KB, patch)
2012-04-19 05:30 PDT, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
Patch (1.37 KB, patch)
2012-04-19 05:37 PDT, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
Patch (1.90 KB, patch)
2012-04-19 11:30 PDT, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Vivek Galatage
Comment 1 2012-04-19 05:09:10 PDT
Pavel, if it is ok with you, I have a patch for the bug and I can upload the same for your review.
Vivek Galatage
Comment 2 2012-04-19 05:17:53 PDT
in method WebInspectorClientFrontend::closeWindow() should explicitly call m_page->inspector()->destroyInspectorPage(); in order to reset the pointers.
Vivek Galatage
Comment 3 2012-04-19 05:30:05 PDT
Created attachment 137882 [details] Patch
Vivek Galatage
Comment 4 2012-04-19 05:37:05 PDT
Created attachment 137883 [details] Patch
Pavel Feldman
Comment 5 2012-04-19 09:10:06 PDT
Comment on attachment 137883 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137883&action=review > Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:75 > + m_page->inspector()->destroyInspectorPage(); It sounds like you should inline destroyInspectorPage into didClose in the WebInspector instead.
Vivek Galatage
Comment 6 2012-04-19 11:30:06 PDT
Created attachment 137932 [details] Patch
WebKit Review Bot
Comment 7 2012-04-19 12:12:59 PDT
Comment on attachment 137932 [details] Patch Clearing flags on attachment: 137932 Committed r114665: <http://trac.webkit.org/changeset/114665>
WebKit Review Bot
Comment 8 2012-04-19 12:13:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.