Summary: | DevTools: assertion failure upon devtools window reopen. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Vivek Galatage <vivekgalatage> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | vivekgalatage, webkit.review.bot, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Pavel Feldman
2011-02-01 08:02:15 PST
Pavel, if it is ok with you, I have a patch for the bug and I can upload the same for your review. in method WebInspectorClientFrontend::closeWindow() should explicitly call m_page->inspector()->destroyInspectorPage(); in order to reset the pointers. Created attachment 137882 [details]
Patch
Created attachment 137883 [details]
Patch
Comment on attachment 137883 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137883&action=review > Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:75 > + m_page->inspector()->destroyInspectorPage(); It sounds like you should inline destroyInspectorPage into didClose in the WebInspector instead. Created attachment 137932 [details]
Patch
Comment on attachment 137932 [details] Patch Clearing flags on attachment: 137932 Committed r114665: <http://trac.webkit.org/changeset/114665> All reviewed patches have been landed. Closing bug. |