Bug 53487

Summary: [Gtk] No need to set text encoding in the provisional phase
Product: WebKit Reporter: Joone Hur <joone>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gustavo, joone.hur, mrobinson, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed Patch
none
Proposed Patch2 none

Joone Hur
Reported 2011-02-01 05:12:56 PST
After loading a html document, other ports initialize the encoding setting, but WebKitGtk+ sets the same encoding again, even tries to set encoding in the provisional phase. This causes unnecessary encoding setting. Please, take a look at the following code. http://trac.webkit.org/browser/trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp#L626 http://trac.webkit.org/browser/trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp#L1028 This patch allows to skip the encoding setting in the cases like other ports such as Mac and Qt.
Attachments
Proposed Patch (3.57 KB, patch)
2011-02-01 05:29 PST, Joone Hur 		no flags
DetailsFormatted DiffDiff
Proposed Patch2 (3.96 KB, patch)
2011-02-03 06:56 PST, Joone Hur 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joone Hur
Comment 1 2011-02-01 05:29:20 PST
Created attachment 80748 [details] Proposed Patch
Martin Robinson
Comment 2 2011-02-01 08:09:03 PST
I recall looking at this issue briefly, but at this point I no longer remember why our implementation differs from Qt. Does this allow us to unskip any tests?j
Joone Hur
Comment 3 2011-02-01 14:37:39 PST
(In reply to comment #2) > I recall looking at this issue briefly, but at this point I no longer remember why our implementation differs from Qt. Does this allow us to unskip any tests?j I tried to find any tests to be unskipped, but I couldn't find them. Actually, there seems to be no problem without this patch until now, but I'm sure that this patch allows WebKitGtk+ to work like other ports. This may prevent unexpected errors.
Joone Hur
Comment 4 2011-02-03 06:56:03 PST
Created attachment 81057 [details] Proposed Patch2 I added more details.
Martin Robinson
Comment 5 2011-02-03 08:24:27 PST
Comment on attachment 81057 [details] Proposed Patch2 Thank you!
WebKit Commit Bot
Comment 6 2011-02-03 21:03:21 PST
Comment on attachment 81057 [details] Proposed Patch2 Clearing flags on attachment: 81057 Committed r77596: <http://trac.webkit.org/changeset/77596>
WebKit Commit Bot
Comment 7 2011-02-03 21:03:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.