Bug 53467

Summary:

Update JSObject storage for new marking API

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

New Bugs

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	ggaren: review+

Oliver Hunt

Reported 2011-01-31 18:23:42 PST

Update JSObject storage for new marking API

Attachments
Patch (39.47 KB, patch) 2011-01-31 18:26 PST, Oliver Hunt	no flags	Details Formatted Diff Diff
Patch (40.26 KB, patch) 2011-02-01 10:03 PST, Oliver Hunt	no flags	Details Formatted Diff Diff
Patch (40.33 KB, patch) 2011-02-01 11:13 PST, Oliver Hunt	ggaren: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Oliver Hunt

Comment 1 2011-01-31 18:26:37 PST

Created attachment 80704 [details] Patch

Build Bot

Comment 2 2011-01-31 19:00:05 PST

Attachment 80704 [details] did not build on win: Build output: http://queues.webkit.org/results/7687078

Geoffrey Garen

Comment 3 2011-01-31 20:10:01 PST

Comment on attachment 80704 [details] Patch LGTM but you gots to fix the windows build.

Oliver Hunt

Comment 4 2011-01-31 22:32:31 PST

(In reply to comment #3) > (From update of attachment 80704 [details]) > LGTM but you gots to fix the windows build. i know but needed ews ot tel me the symbol :)

Oliver Hunt

Comment 5 2011-02-01 10:03:31 PST

Created attachment 80778 [details] Patch

Oliver Hunt

Comment 6 2011-02-01 10:12:23 PST

Comment on attachment 80778 [details] Patch Will probably need one more revision to get windows ubild fixed

Build Bot

Comment 7 2011-02-01 11:02:59 PST

Attachment 80778 [details] did not build on win: Build output: http://queues.webkit.org/results/7687238

Oliver Hunt

Comment 8 2011-02-01 11:13:50 PST

Created attachment 80790 [details] Patch

WebKit Review Bot

Comment 9 2011-02-01 11:26:36 PST

Attachment 80704 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/runtime/BooleanObject.h:30: The parameter name "globalData" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.

Geoffrey Garen

Comment 10 2011-02-01 11:38:44 PST

Comment on attachment 80790 [details] Patch r=me

WebKit Review Bot

Comment 11 2011-02-01 11:58:43 PST

Attachment 80778 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/runtime/BooleanObject.h:30: The parameter name "globalData" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 12 2011-02-01 12:06:08 PST

Attachment 80790 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/runtime/BooleanObject.h:30: The parameter name "globalData" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.

Oliver Hunt

Comment 13 2011-02-01 12:17:42 PST

Committed r77269: <http://trac.webkit.org/changeset/77269>

Note You need to log in before you can comment on or make changes to this bug.