Bug 53448

Summary: Some favicons not correctly decoded by Chromium/Mac
Product: WebKit Reporter: Matthew Vosburgh <maf>
Component: ImagesAssignee: Matthew Vosburgh <maf>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.6   
Attachments:
Description Flags
Use the same frame selection logic as the WebImageSkia code, rather than just picking frame[0].
none
Patch kbr: review+

Matthew Vosburgh
Reported 2011-01-31 13:01:11 PST
What steps will reproduce the problem? 1. Bookmark "www.frys.com" in a Chromium-based browser. Actual: No favicon show up. It is blank. Expected: Show Favicon. See chromium bug http://code.google.com/p/chromium/issues/detail?id=34797 The code responsible is Mac/Chromium specific code in the WebKit tree, specifically in WebKit/chromium/src/WebImageCG.cpp. The fix is to change the implementation of WebImage::fromData() to be more discriminating, using equivalent code to the WebImageSkia implementation.
Attachments
Use the same frame selection logic as the WebImageSkia code, rather than just picking frame[0]. (2.00 KB, patch)
2011-01-31 13:31 PST, Matthew Vosburgh 		no flags
DetailsFormatted DiffDiff
Patch (2.56 KB, patch)
2011-02-02 12:23 PST, Kenneth Russell 		kbr: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matthew Vosburgh
Comment 1 2011-01-31 13:31:32 PST
Created attachment 80674 [details] Use the same frame selection logic as the WebImageSkia code, rather than just picking frame[0].
Kenneth Russell
Comment 2 2011-02-02 12:23:53 PST
Created attachment 80949 [details] Patch
Kenneth Russell
Comment 3 2011-02-02 12:24:43 PST
Re-indented patch for maf and provided ChangeLog entry. Verified fix manually in Chromium.
Kenneth Russell
Comment 4 2011-02-02 12:25:14 PST
Comment on attachment 80949 [details] Patch Looks fine. Verified fix in Chromium.
Kenneth Russell
Comment 5 2011-02-02 12:26:15 PST
Committed r77400: <http://trac.webkit.org/changeset/77400>
Note You need to log in before you can comment on or make changes to this bug.