Bug 53432

Summary: Make LayerTreeHost an abstract base class and make LayerTreeHostMac inherit from it
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch aroben: review+

Anders Carlsson
Reported 2011-01-31 09:54:58 PST
Make LayerTreeHost an abstract base class and make LayerTreeHostMac inherit from it
Attachments
Patch (13.47 KB, patch)
2011-01-31 09:58 PST, Anders Carlsson 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-01-31 09:58:03 PST
Created attachment 80651 [details] Patch
Adam Roben (:aroben)
Comment 2 2011-01-31 10:02:44 PST
Comment on attachment 80651 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80651&action=review Maybe WebPorcess/WebPage/ca/LayerTreeHostCA.mm would be more appropriate? > Source/WebKit2/WebProcess/WebPage/LayerTreeHost.cpp:47 > + return adoptPtr(static_cast<LayerTreeHost*>(new LayerTreeHostMac(webPage, graphicsLayer))); Is the cast really needed here?
Anders Carlsson
Comment 3 2011-01-31 10:08:15 PST
Committed r77139: <http://trac.webkit.org/changeset/77139>
Note You need to log in before you can comment on or make changes to this bug.