Bug 53432

Summary:

Make LayerTreeHost an abstract base class and make LayerTreeHostMac inherit from it

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	aroben: review+

Description Anders Carlsson 2011-01-31 09:54:58 PST

Make LayerTreeHost an abstract base class and make LayerTreeHostMac inherit from it

Comment 1 Anders Carlsson 2011-01-31 09:58:03 PST

Created attachment 80651 [details]
Patch

Comment 2 Adam Roben (:aroben) 2011-01-31 10:02:44 PST

Comment on attachment 80651 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80651&action=review

Maybe WebPorcess/WebPage/ca/LayerTreeHostCA.mm would be more appropriate?

> Source/WebKit2/WebProcess/WebPage/LayerTreeHost.cpp:47
> +    return adoptPtr(static_cast<LayerTreeHost*>(new LayerTreeHostMac(webPage, graphicsLayer)));

Is the cast really needed here?

Comment 3 Anders Carlsson 2011-01-31 10:08:15 PST

Committed r77139: <http://trac.webkit.org/changeset/77139>