| Summary: | [Qt] WebKit fails to compile for Qt when WebGL enabled | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andrew Wason <rectalogic> | ||||||||
| Component: | WebGL | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | adawit, benjamin, cmarrin, commit-queue, webkit.review.bot | ||||||||
| Priority: | P3 | Keywords: | Qt, QtTriaged | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 54138 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Andrew Wason
2011-01-31 09:39:39 PST
Created attachment 80653 [details]
update Qt WebGL implementation so it builds and runs
Does that work when compiled? I don't like the idea of adding stubs just to discover later the thing is not working when running the tests. (In reply to comment #2) > Does that work when compiled? I don't like the idea of adding stubs just to discover > later the thing is not working when running the tests. Yes, it works when compiled if "Toggle use of QGraphicsView" is unchecked in QtTestBrowser, or if it is checked then "Toggle Accelerated Compositing" must be unchecked - I think this was a requirement before this patch too. It looks like the stubbed out DrawingBuffer is only used if ACCELERATED_2D_CANVAS is enabled. The only place I can find a call to createDrawingBuffer() is in Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:CanvasRenderingContext2D::CanvasRenderingContext2D() and it is wrapped in ACCELERATED_2D_CANVAS ifdef. Attachment 80653 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/gpu/qt/DrawingBufferQt.cpp:52: Use 0 instead of NULL. [readability/null] [5]
Source/WebCore/platform/graphics/gpu/qt/DrawingBufferQt.cpp:58: Use 0 instead of NULL. [readability/null] [5]
Total errors found: 2 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 80791 [details]
update Qt WebGL implementation so it builds and runs
change NULL to 0 to pass style-queue
Created attachment 81372 [details]
update Qt WebGL implementation so it builds and runs
Updated patch with more complete DrawingBufferQt.cpp implementation based on DrawingBufferMac.mm
*** Bug 54006 has been marked as a duplicate of this bug. *** A site that can be used for testing: https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/webgl-conformance-tests.html *** Bug 47566 has been marked as a duplicate of this bug. *** Comment on attachment 81372 [details]
update Qt WebGL implementation so it builds and runs
Looks fine to me as long as it's been built and tested.
The commit-queue encountered the following flaky tests while processing attachment 81372 [details]: http/tests/webarchive/test-preload-resources.html bug 54404 (author: ddkilzer@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 81372 [details] update Qt WebGL implementation so it builds and runs Clearing flags on attachment: 81372 Committed r78495: <http://trac.webkit.org/changeset/78495> All reviewed patches have been landed. Closing bug. |