Bug 53309

Summary: Web Inspector: "Clear CPU profiles" button title is too specific having multiple profile types.
Product: WebKit Reporter: Mikhail Naganov <mnaganov>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
yurys: review-, mnaganov: commit-queue-
now full diff yurys: review+, mnaganov: commit-queue-

Mikhail Naganov
Reported 2011-01-28 09:56:27 PST
As besides CPU profiles there can be heap profiles, the name of the button: "Clear CPU profiles" is misleading. My proposal is to change the text to "Clear all profiles".
Attachments
patch (648 bytes, patch)
2011-01-28 10:01 PST, Mikhail Naganov 		yurys: review-
mnaganov: commit-queue-
DetailsFormatted DiffDiff
now full diff (1.94 KB, patch)
2011-01-28 10:23 PST, Mikhail Naganov 		yurys: review+
mnaganov: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mikhail Naganov
Comment 1 2011-01-28 10:01:07 PST
Created attachment 80461 [details] patch
Yury Semikhatsky
Comment 2 2011-01-28 10:22:40 PST
Comment on attachment 80461 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=80461&action=review > Source/WebCore/ChangeLog:10 > + * inspector/front-end/ProfilesPanel.js: You seem to have missed the changes.
Mikhail Naganov
Comment 3 2011-01-28 10:23:41 PST
Created attachment 80463 [details] now full diff
Mikhail Naganov
Comment 4 2011-01-31 02:45:29 PST
Manually committed http://trac.webkit.org/changeset/77116 2011-01-31 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Yury Semikhatsky. WebInspector: Change button title from "Clear CPU profiles" to "Clear all profiles". https://bugs.webkit.org/show_bug.cgi?id=53309 * English.lproj/localizedStrings.js: * inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel):
Note You need to log in before you can comment on or make changes to this bug.