Bug 53303

Summary: Web Inspector: allow remote debugging with front-end served from the cloud.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed change.
yurys: review-
[PATCH] A better patch. yurys: review+

Pavel Feldman
Reported 2011-01-28 08:30:31 PST
Sometimes we don't want to serve front-end from the browser. Make it possible. Patch to follow.
Attachments
[PATCH] Proposed change. (1.70 KB, patch)
2011-01-28 08:36 PST, Pavel Feldman 		yurys: review-
DetailsFormatted DiffDiff
[PATCH] A better patch. (1.62 KB, patch)
2011-01-28 08:41 PST, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-01-28 08:36:32 PST
Created attachment 80453 [details] [PATCH] Proposed change.
Yury Semikhatsky
Comment 2 2011-01-28 08:40:17 PST
Comment on attachment 80453 [details] [PATCH] Proposed change. View in context: https://bugs.webkit.org/attachment.cgi?id=80453&action=review > Source/WebCore/inspector/front-end/inspector.js:482 > + if (WebInspector.socket) { Did you mean !WebInspector.socket
Pavel Feldman
Comment 3 2011-01-28 08:41:05 PST
Created attachment 80454 [details] [PATCH] A better patch.
Yury Semikhatsky
Comment 4 2011-01-28 08:44:47 PST
Comment on attachment 80454 [details] [PATCH] A better patch. View in context: https://bugs.webkit.org/attachment.cgi?id=80454&action=review > Source/WebCore/inspector/front-end/inspector.js:479 > + else if ("page" in WebInspector.queryParamsObject) Could you factor out if ("page" in WebInspector.queryParamsObject) in an outer if block?
Pavel Feldman
Comment 5 2011-01-28 08:57:08 PST
Ok, ok, no hurry anymore. Landed beautified. Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog M Source/WebCore/inspector/front-end/inspector.js Committed r76947
Note You need to log in before you can comment on or make changes to this bug.