Summary: | DOM: Move DocumentOrderedMap from Document into separate files | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Roland Steiner <rolandsteiner> | ||||||||
Component: | DOM | Assignee: | Roland Steiner <rolandsteiner> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, darin, dglazkov, morrita, webkit-ews | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 52963 | ||||||||||
Attachments: |
|
Description
Roland Steiner
2011-01-28 01:05:58 PST
Created attachment 80432 [details]
Patch
Attachment 80432 [details] did not build on win: Build output: http://queues.webkit.org/results/7560379 Attachment 80432 [details] did not build on qt: Build output: http://queues.webkit.org/results/7657049 Comment on attachment 80432 [details]
Patch
This is great! Please update all build systems to ensure no bot breakages.
Created attachment 80617 [details]
Patch, try again
Attachment 80617 [details] did not build on win: Build output: http://queues.webkit.org/results/7680166 Attachment 80617 [details] did not build on qt: Build output: http://queues.webkit.org/results/7567944 Created attachment 80623 [details]
Patch, try de third
Hmmm... any idea what issues 'gtk' and 'mac' have patching the .vcproj file? 'win' seems to like it... @_@? Comment on attachment 80623 [details] Patch, try de third View in context: https://bugs.webkit.org/attachment.cgi?id=80623&action=review Changes to vcproj suck. I don't know why, but I get purples on them too. But your project changes look good, except for android. Let's see if this works. > Source/WebCore/ChangeLog:13 > + * GNUMakefile.am: I think you're going to break Android build. Reverted r77229 for reason: revert mysterious build breakage Committed r77231: <http://trac.webkit.org/changeset/77231> committed in r77239, with additional entries in Android.mk and CMakeLists.txt, so as to hopefully not-break Android and EFL. |