Bug 53284

Summary: Build fix for Mac Intel Debug after r76916
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
buildfix
none
2nd try none

Laszlo Gombos
Reported 2011-01-27 23:11:52 PST
Macro redefinition In file included from /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/WebKitBuild/Debug/DerivedSources/WebKit2/WebPageMessages.h:25, from /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Source/WebKit2/UIProcess/cf/WebPageProxyCF.cpp:33: /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/Source/WebKit2/config.h:38:1: error: "EXTERN_C_BEGIN" redefined /usr/include/c++/4.2.1/i686-apple-darwin10/x86_64/bits/c++config.h:320:99: error: this is the location of the previous definition
Attachments
buildfix (1.09 KB, patch)
2011-01-27 23:14 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
2nd try (1.12 KB, patch)
2011-01-27 23:42 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2011-01-27 23:14:43 PST
Created attachment 80422 [details] buildfix
Laszlo Gombos
Comment 2 2011-01-27 23:42:21 PST
Created attachment 80423 [details] 2nd try
WebKit Review Bot
Comment 3 2011-01-27 23:43:41 PST
Attachment 80423 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/config.h:38: #ifndef header guard has wrong style, please use: WTF_config_h [build/header_guard] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Maciej Stachowiak
Comment 4 2011-01-27 23:44:42 PST
Comment on attachment 80423 [details] 2nd try r=me
Build Bot
Comment 5 2011-01-27 23:48:19 PST
Attachment 80422 [details] did not build on win: Build output: http://queues.webkit.org/results/7640137
Laszlo Gombos
Comment 6 2011-01-28 00:04:54 PST
Comment on attachment 80423 [details] 2nd try Landed as http://trac.webkit.org/changeset/76922. Clearing flags.
Note You need to log in before you can comment on or make changes to this bug.