Bug 53278

Summary: WebKit2: the cookies used by the WebKit2 Web Process should not go in a top-level directory
Product: WebKit Reporter: Jessie Berlin <jberlin>
Component: WebKit2Assignee: Jessie Berlin <jberlin>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, jberlin, sfalken
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: Windows 7   
Attachments:
Description Flags
Patch none

Jessie Berlin
Reported 2011-01-27 18:41:16 PST
<rdar://problem/8927925>
Attachments
Patch (3.55 KB, patch)
2011-01-27 18:49 PST, Jessie Berlin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jessie Berlin
Comment 1 2011-01-27 18:49:56 PST
Created attachment 80399 [details] Patch
Steve Falkenburg
Comment 2 2011-01-28 09:20:22 PST
Comment on attachment 80399 [details] Patch Seems strange that we use 522+ in this plist, and also in WebKit's Info.plist. JavaScriptCore uses 530, which is also out of date. On Windows, this version doesn't matter - we should probably just remove it from the string in these Windows Info.plist files (starting with this one).
Jessie Berlin
Comment 3 2011-01-28 13:10:48 PST
Holding off on committing as there is some discussion as to whether this is the right approach (maybe we can still figure out a way to share the cookies)
Jessie Berlin
Comment 4 2011-01-31 10:55:04 PST
Removed the following lines: <key>CFBundleShortVersionString</key> <string>522+</string> <key>CFBundleVersion</key> <string>522+</string> Also changed the copyright date to be just 2011, since this file and bundle is new.
Jessie Berlin
Comment 5 2011-01-31 11:27:07 PST
Comment on attachment 80399 [details] Patch Committed in r77147 http://trac.webkit.org/changeset/77147
Jessie Berlin
Comment 6 2011-03-25 09:32:24 PDT
I appear to have forgotten to mark this as fixed. Doing so now.
Note You need to log in before you can comment on or make changes to this bug.