Summary: | WebKit2: the cookies used by the WebKit2 Web Process should not go in a top-level directory | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jessie Berlin <jberlin> | ||||
Component: | WebKit2 | Assignee: | Jessie Berlin <jberlin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aroben, jberlin, sfalken | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | Windows 7 | ||||||
Attachments: |
|
Description
Jessie Berlin
2011-01-27 18:41:16 PST
Created attachment 80399 [details]
Patch
Comment on attachment 80399 [details]
Patch
Seems strange that we use 522+ in this plist, and also in WebKit's Info.plist. JavaScriptCore uses 530, which is also out of date. On Windows, this version doesn't matter - we should probably just remove it from the string in these Windows Info.plist files (starting with this one).
Holding off on committing as there is some discussion as to whether this is the right approach (maybe we can still figure out a way to share the cookies) Removed the following lines: <key>CFBundleShortVersionString</key> <string>522+</string> <key>CFBundleVersion</key> <string>522+</string> Also changed the copyright date to be just 2011, since this file and bundle is new. Comment on attachment 80399 [details] Patch Committed in r77147 http://trac.webkit.org/changeset/77147 I appear to have forgotten to mark this as fixed. Doing so now. |