Bug 53277

Summary:

Add basic rubber banding support

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

Frames

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.6

Attachments:

Description	Flags
Patch	mjs: review+

Description Sam Weinig 2011-01-27 18:16:17 PST

Add basic rubber bandings support.

Comment 1 Sam Weinig 2011-01-27 18:18:07 PST

Created attachment 80393 [details]
Patch

Comment 2 Maciej Stachowiak 2011-01-27 18:39:54 PST

Comment on attachment 80393 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80393&action=review

r=me with minor comments.

> Source/WebCore/ChangeLog:5
> +        Add basic rubber bandings support

s/bandings/banding/

> Source/WebCore/page/EventHandler.cpp:2047
> +    // that if a frame gets a gesture begin gesture, it gets the corrisponding

s/corrisponding/corresponding/

> Source/WebCore/platform/mac/ScrollAnimatorMac.h:44
> +#define SUPPORT_RUBBER_BANDING 1

This should probably be an ENABLE macro.

Comment 3 Sam Weinig 2011-01-28 11:06:06 PST

Landed in r76956.

Comment 4 WebKit Review Bot 2011-01-28 12:18:10 PST

http://trac.webkit.org/changeset/76956 might have broken Leopard Intel Release (Tests)