Bug 53273

Summary:

Rename Typed Array slice() to subset()

Product:

WebKit

Reporter:

Kenneth Russell <kbr>

Component:

WebGL

Assignee:

Kenneth Russell <kbr>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarrin, jamesr, zmo

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

53618

Attachments:

Description	Flags
Patch	jamesr: review+, kbr: commit-queue-

Description Kenneth Russell 2011-01-27 17:28:31 PST

The WebGL working group resolved at the most recent face-to-face to rename the slice() method on Typed Arrays to subset() to avoid collisions with ECMAScript arrays' slice() method, because Typed Arrays' slices have slightly different semantics (they reference the same underlying data instead of copying it). The WebKit implementation needs to be changed to track this and the conformance tests updated.

Comment 1 Kenneth Russell 2011-01-27 17:35:39 PST

Created attachment 80385 [details]
Patch

Comment 2 Zhenyao Mo 2011-01-27 17:53:19 PST

Looks good.

Comment 3 James Robinson 2011-01-27 18:04:07 PST

Comment on attachment 80385 [details]
Patch

R=me. I hope it compiles everywhere :)

Comment 4 Kenneth Russell 2011-01-27 18:15:45 PST

Committed r76892: <http://trac.webkit.org/changeset/76892>