Bug 53273

Summary: Rename Typed Array slice() to subset()
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, jamesr, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 53618    
Attachments:
Description Flags
Patch jamesr: review+, kbr: commit-queue-

Kenneth Russell
Reported 2011-01-27 17:28:31 PST
The WebGL working group resolved at the most recent face-to-face to rename the slice() method on Typed Arrays to subset() to avoid collisions with ECMAScript arrays' slice() method, because Typed Arrays' slices have slightly different semantics (they reference the same underlying data instead of copying it). The WebKit implementation needs to be changed to track this and the conformance tests updated.
Attachments
Patch (49.20 KB, patch)
2011-01-27 17:35 PST, Kenneth Russell 		jamesr: review+
kbr: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2011-01-27 17:35:39 PST
Created attachment 80385 [details] Patch
Zhenyao Mo
Comment 2 2011-01-27 17:53:19 PST
Looks good.
James Robinson
Comment 3 2011-01-27 18:04:07 PST
Comment on attachment 80385 [details] Patch R=me. I hope it compiles everywhere :)
Kenneth Russell
Comment 4 2011-01-27 18:15:45 PST
Committed r76892: <http://trac.webkit.org/changeset/76892>
Note You need to log in before you can comment on or make changes to this bug.