Bug 53208

Summary: BinarySemaphore should wrap a Win32 event
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: WebKit2Assignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, andersca, eric, sam, webkit.review.bot
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Bug Depends on:    
Bug Blocks: 53209    
Attachments:
Description Flags
Change BinarySemaphore to wrap an auto-reset Win32 event on Windows hyatt: review+

Adam Roben (:aroben)
Reported 2011-01-26 17:23:26 PST
BinarySemaphore should wrap a Win32 event. This will make it more efficient, and make it able to be used in functions like ::WaitForMultipleObjects.
Attachments
Change BinarySemaphore to wrap an auto-reset Win32 event on Windows (12.02 KB, patch)
2011-01-27 18:45 PST, Adam Roben (:aroben) 		hyatt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-01-26 18:15:58 PST
<rdar://problem/8922490>
Adam Roben (:aroben)
Comment 2 2011-01-27 18:45:30 PST
Created attachment 80398 [details] Change BinarySemaphore to wrap an auto-reset Win32 event on Windows
Dave Hyatt
Comment 3 2011-01-27 18:53:01 PST
Comment on attachment 80398 [details] Change BinarySemaphore to wrap an auto-reset Win32 event on Windows Looks fine. r=me
Adam Roben (:aroben)
Comment 4 2011-01-28 12:20:35 PST
Fixed in r76967.
Adam Roben (:aroben)
Comment 5 2011-01-28 12:20:46 PST
...so I should close the bug.
WebKit Review Bot
Comment 6 2011-01-28 12:48:09 PST
http://trac.webkit.org/changeset/76967 might have broken Chromium Win Release
Note You need to log in before you can comment on or make changes to this bug.