Bug 53200

Summary: Generalize the mechanism view-sources uses to remember the source for an HTMLToken
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 49845    
Attachments:
Description Flags
Patch
none
Patch for landing abarth: commit-queue+

Adam Barth
Reported 2011-01-26 15:48:03 PST
Generalize the mechanism view-sources uses to remember the source for an HTMLToken
Attachments
Patch (25.45 KB, patch)
2011-01-26 15:58 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (24.90 KB, patch)
2011-01-27 12:04 PST, Adam Barth 		abarth: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-01-26 15:58:07 PST
Created attachment 80251 [details] Patch
Eric Seidel (no email)
Comment 2 2011-01-26 16:22:39 PST
Comment on attachment 80251 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80251&action=review This seems sane. Thank you for keeping it small. > Source/WebCore/ChangeLog:37 > + - This function should eventuall be folded into HTMLTokenizer. eventuall > Source/WebCore/html/parser/HTMLSourceTracker.cpp:44 > + token.end(input.current().numberOfCharactersConsumed()); You shoudl add a FIXME about moving this to the tokenizer. > Source/WebCore/html/parser/HTMLSourceTracker.h:39 > + void start(const HTMLInputStream&, HTMLToken&); You should make it clear that this can be called multipel times.
Adam Barth
Comment 3 2011-01-27 12:04:47 PST
Created attachment 80353 [details] Patch for landing
Adam Barth
Comment 4 2011-01-27 13:53:18 PST
Committed r76835: <http://trac.webkit.org/changeset/76835>
Note You need to log in before you can comment on or make changes to this bug.