Summary: | Generalize the mechanism view-sources uses to remember the source for an HTMLToken | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dbates, eric | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 49845 | ||||||||
Attachments: |
|
Description
Adam Barth
2011-01-26 15:48:03 PST
Created attachment 80251 [details]
Patch
Comment on attachment 80251 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80251&action=review This seems sane. Thank you for keeping it small. > Source/WebCore/ChangeLog:37 > + - This function should eventuall be folded into HTMLTokenizer. eventuall > Source/WebCore/html/parser/HTMLSourceTracker.cpp:44 > + token.end(input.current().numberOfCharactersConsumed()); You shoudl add a FIXME about moving this to the tokenizer. > Source/WebCore/html/parser/HTMLSourceTracker.h:39 > + void start(const HTMLInputStream&, HTMLToken&); You should make it clear that this can be called multipel times. Created attachment 80353 [details]
Patch for landing
Committed r76835: <http://trac.webkit.org/changeset/76835> |