| Summary: | [chromium] Implement reflections for composited layers | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Vangelis Kokkevis <vangelis> | ||||
| Component: | WebCore Misc. | Assignee: | Vangelis Kokkevis <vangelis> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | backer, jamesr, kbr, mihaip | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 53679 | ||||||
| Attachments: |
|
||||||
|
Description
Vangelis Kokkevis
2011-01-26 10:39:48 PST
Created attachment 80825 [details]
Patch
Comment on attachment 80825 [details]
Patch
Looks good to me, in particular the drawableContentRect() refactoring. Do we need test expectations updates for the chromium-gpu port?
Committed r77425: <http://trac.webkit.org/changeset/77425> (In reply to comment #2) > (From update of attachment 80825 [details]) > Looks good to me, in particular the drawableContentRect() refactoring. Do we need test expectations updates for the chromium-gpu port? New test expectations will be harvested from build bots and updated once the patch lands. At the moment all compositing tests are marked as PASS FAIL so they won't turn the chromium-gpu bot red. Regression on http://webkit.org/blog/386/3d-transforms/ ASSERTION FAILED: m_ptr (third_party/WebKit/Source/JavaScriptCore/wtf/OwnPtr.h:66 typename WTF::RemovePointer<T>::Type* WTF::OwnPtr<T>::operator->() const [with T = WebCore::RenderSurfaceChromium]) This is on the Linux build. The regression first occurred on a WebKit roll (chromium r73597). From this, I narrowed it down to this particular WebKit commit. Based on advice from #webkit, I've filed a separate bug for the regression (https://bugs.webkit.org/show_bug.cgi?id=53679). |