Bug 53162

Summary: Web Inspector: visualize \n in strings as ↵ in stack variables sidebar.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed change. yurys: review+

Description Pavel Feldman 2011-01-25 23:33:54 PST
Upstreamed from crbug.com/32855.
Comment 1 Patrick Mueller 2011-01-26 06:45:34 PST
Great idea.  Perhaps some others as well, like tab as → (right pointing arrow)
Comment 2 Pavel Feldman 2011-01-26 08:38:14 PST
Created attachment 80197 [details]
[PATCH] Proposed change.
Comment 3 Yury Semikhatsky 2011-01-26 09:03:31 PST
Comment on attachment 80197 [details]
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=80197&action=review

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:186
> +            description = description.replace(/\n/g, "\u21B5");

A short comment would be helpful here.
Comment 4 Joseph Pecoraro 2011-01-26 09:10:51 PST
Comment on attachment 80197 [details]
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=80197&action=review

>> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:186
>> +            description = description.replace(/\n/g, "\u21B5");
> 
> A short comment would be helpful here.

yurys++
Comment 5 Pavel Feldman 2011-01-26 09:19:35 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       Source/WebCore/ChangeLog
        M       Source/WebCore/inspector/front-end/ObjectPropertiesSection.js
Committed r76692