Summary: | new-run-webkit-tests: add first stub of test_runner2 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||||
Component: | New Bugs | Assignee: | Dirk Pranke <dpranke> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric, mihaip, ojan, tony | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | 53156 | ||||||||
Bug Blocks: | 49566, 53158 | ||||||||
Attachments: |
|
Description
Dirk Pranke
2011-01-25 19:37:37 PST
Created attachment 80162 [details]
Patch
Comment on attachment 80162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80162&action=review > Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:34 > +The TestRunner class runs a series of tests (TestType interface) against a set > +of test files. If a test file fails a TestType, it returns a list TestFailure > +objects to the TestRunner. The TestRunner then aggregates the TestFailures to > +create a final report. This comment doesn't seem to describe this file (TestRunner2). Maybe mention what this is going to be used for and what it does now. > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:468 > + Can you add a test with --child-processes and --worker-model? (In reply to comment #2) > (From update of attachment 80162 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=80162&action=review > > > Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:34 > > +The TestRunner class runs a series of tests (TestType interface) against a set > > +of test files. If a test file fails a TestType, it returns a list TestFailure > > +objects to the TestRunner. The TestRunner then aggregates the TestFailures to > > +create a final report. > > This comment doesn't seem to describe this file (TestRunner2). Maybe mention what this is going to be used for and what it does now. > Yeah, looks like I just copied&pasted that from the old file and it's not even a very good comment. I'll put in something better. > > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:468 > > + > > Can you add a test with --child-processes and --worker-model? Will do. Created attachment 80857 [details]
update w/ review feedback from tony
Committed r77341: <http://trac.webkit.org/changeset/77341> |