Bug 53151

Summary: Range and number inputs should reject increment and decrement by keyboard or mouse wheel if they are disabled or read-only
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, adele, darin, dglazkov, eric, hamaji, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://code.google.com/p/chromium/issues/detail?id=70740
Attachments:
Description Flags
Patch none

Kent Tamura
Reported 2011-01-25 17:39:11 PST
Range and number inputs should reject increment and decrement by keyboard or mouse wheel if they are disabled or read-only
Attachments
Patch (7.64 KB, patch)
2011-01-25 17:41 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2011-01-25 17:41:38 PST
Created attachment 80150 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2011-01-25 17:45:35 PST
Comment on attachment 80150 [details] Patch ok. Is this the typical way we handle disabled and readOnly for elements?
Kent Tamura
Comment 3 2011-01-25 17:49:39 PST
(In reply to comment #2) > ok. Is this the typical way we handle disabled and readOnly for elements? I think we have no other way. e.g. We can't skip all of key event handling in HTMLInputElement.cpp because we'd like to handle ⌘-C or Ctrl-c even if the element is disabled or read-only.
Kent Tamura
Comment 4 2011-01-25 19:51:03 PST
Comment on attachment 80150 [details] Patch Clearing flags on attachment: 80150 Committed r76662: <http://trac.webkit.org/changeset/76662>
Kent Tamura
Comment 5 2011-01-25 19:51:11 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2011-01-25 20:53:46 PST
http://trac.webkit.org/changeset/76662 might have broken Leopard Intel Release (Tests)
Note You need to log in before you can comment on or make changes to this bug.