Bug 53150 – initial support for close() in indexeddb backend

• Component: New Bugs
• Status: RESOLVED FIXED

initial support for close() in indexeddb backend

Created attachment 80153 [details]
Patch

[Jeremy Orlow]

Comment on attachment 80153 [details]
Patch

change the idl and add a test please

Created attachment 80267 [details]
Patch

[Jeremy Orlow]

Comment on attachment 80267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80267&action=review

> LayoutTests/storage/indexeddb/transaction-after-close.html:66
> +    evalAndLog("objectStore.put('a', 'b')");

Whenever you do something, you should at least set an onerror handler to be unexpectedErrorCallback

> LayoutTests/storage/indexeddb/transaction-after-close.html:87
> +    currentTransaction.onabort = done;

It's probably worth doing something on this transaction and verifying its onsuccess fires

> Source/WebCore/storage/IDBDatabase.cpp:48
> +    : m_backend(backend), m_noNewTransactions(false)

, and such on newline

> Source/WebCore/storage/IDBDatabase.cpp:-129
> -    m_backend->close();

The setVersion logic is going to need to run in the backend, so you still need to do this.

> Source/WebCore/storage/IDBDatabase.cpp:133
> +    m_noNewTransactions = true;

Right now, we try to do as much of the logic as is possible in the backend.  I think we should probably move this there especially since we need to plumb close anyway.

> Source/WebCore/storage/IDBDatabase.h:80
> +    bool m_noNewTransactions;

this should be on the backend object

[Jeremy Orlow]

Oh...the logic does need to be in the frontend.  OK....but still do the layout test and style nits.

Created attachment 80283 [details]
Patch

[Jeremy Orlow]

Comment on attachment 80283 [details]
Patch

r=me