Bug 5310

Summary: Switch QRegion from using NSBezierPath to CGPath
Product: WebKit Reporter: mitz
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Enhancement    
Priority: P3    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
replace the NSBezierPath with a CGPath
darin: review-
replace the NSBezierPath with a CGPath hyatt: review+

mitz
Reported 2005-10-09 15:25:26 PDT
Attachments
replace the NSBezierPath with a CGPath (3.53 KB, patch)
2005-10-09 15:26 PDT, mitz 		darin: review-
DetailsFormatted DiffDiff
replace the NSBezierPath with a CGPath (3.71 KB, patch)
2005-10-10 10:46 PDT, mitz 		hyatt: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2005-10-09 15:26:41 PDT
Created attachment 4272 [details] replace the NSBezierPath with a CGPath
mitz
Comment 2 2005-10-09 15:28:43 PDT
Comment on attachment 4272 [details] replace the NSBezierPath with a CGPath I thought it might solve an issue with [NSBezierPath containsPoint:] not always returning YES when it should, but CGPath has the same problem.
Darin Adler
Comment 3 2005-10-09 15:58:25 PDT
Comment on attachment 4272 [details] replace the NSBezierPath with a CGPath We use 0 instead of NULL in our code. Otherwise looks perfect!
mitz
Comment 4 2005-10-10 10:46:49 PDT
Created attachment 4292 [details] replace the NSBezierPath with a CGPath Changed NULLs to 0s and removed NSBezierPath comment
Dave Hyatt
Comment 5 2005-10-17 20:45:11 PDT
Comment on attachment 4292 [details] replace the NSBezierPath with a CGPath r=me
Eric Seidel (no email)
Comment 6 2005-11-29 02:10:32 PST
Landed.
Darin Adler
Comment 7 2006-03-29 06:31:01 PST
Turns out this caused a bug. Currently the bug report is only in Bugzilla, but there seem to be cases that NSBezierPath handles better than CGPath. Specifically: http://www.intervalworld.com/web/cs?a=1500 On that map if you mouse over the US you'll get some areas that say "Europe" or "Asia".
mitz
Comment 8 2006-03-29 14:54:56 PST
(In reply to comment #7) > Turns out this caused a bug. Currently the bug report is only in Bugzilla, but > there seem to be cases that NSBezierPath handles better than CGPath. And there are cases that CGPath handles better the NSBezierPath. I don't know which are more common.
Note You need to log in before you can comment on or make changes to this bug.