Bug 53084

Summary: [cairo] Use CAIRO_OPERATOR_DARKEN when available
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
mrobinson: review-
Updated patch with unskipped test none

Carlos Garcia Campos
Reported 2011-01-25 06:58:57 PST
We are currenlty using CAIRO_OPERATOR_SATURATE for CompositePlusDarker which is wrong. Since cairo 1.10 there's CAIRO_OPERATOR_DARKEN that we could use.
Attachments
Patch (1.48 KB, patch)
2011-01-25 07:03 PST, Carlos Garcia Campos 		mrobinson: review-
DetailsFormatted DiffDiff
Updated patch with unskipped test (9.00 KB, patch)
2011-01-26 03:19 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2011-01-25 07:03:37 PST
Created attachment 80062 [details] Patch This would allow us to unskip test fast/canvas/canvas-composite.html but bots don't have cairo 1.10 :-(
Martin Robinson
Comment 2 2011-01-25 08:54:20 PST
Great. Hopefully we can get the bots up to date. This may not be an issue for too much longer though: https://bugs.webkit.org/show_bug.cgi?id=43739
Martin Robinson
Comment 3 2011-01-25 13:49:30 PST
Comment on attachment 80062 [details] Patch This looks great to me, but we should also unskip the test now that the bots have the necessary Cairo version.
Carlos Garcia Campos
Comment 4 2011-01-26 03:19:45 PST
Created attachment 80178 [details] Updated patch with unskipped test
Carlos Garcia Campos
Comment 5 2011-01-26 10:17:26 PST
Committed r76697: <http://trac.webkit.org/changeset/76697>
Note You need to log in before you can comment on or make changes to this bug.