Bug 53066

Summary: Web Inspector: fix data url's status and timing the network panel.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, commit-queue, joepeck, keishi, loislo, pfeldman, pmuellr, rik, tonyg, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
pfeldman: review-
Patch with fixes none

Description Pavel Feldman 2011-01-24 22:23:45 PST 
Today, data urls are shown as pending requests in the network panel. There should be no data urls in the network panel at all since there is no associated network request.
Comment 1 Pavel Feldman 2011-01-24 22:24:31 PST 
(crbug.com/69810)
Comment 2 Vsevolod Vlasov 2011-04-05 09:13:15 PDT 
Created attachment 88246 [details]
Patch

Data URL resources now show "(data url)" in status cell.
Comment 3 Pavel Feldman 2011-04-05 10:15:05 PDT 
Comment on attachment 88246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88246&action=review

> Source/WebCore/inspector/front-end/NetworkPanel.js:1524
> +                this._statusCell.textContent = WebInspector.UIString("(data url)");

You need to update English.lproj/localizedStrings.js with new string.

> Source/WebCore/inspector/front-end/NetworkPanel.js:1525
> +                this._statusCell.addStyleClass("network-dim-cell");

Seems like this line is common.

> Source/WebCore/inspector/front-end/Resource.js:716
> +    isFromDataURL: function()

nit: isDataURL
Comment 4 Vsevolod Vlasov 2011-04-05 10:52:41 PDT 
Created attachment 88276 [details]
Patch with fixes
Comment 5 WebKit Commit Bot 2011-04-05 14:59:27 PDT 
Comment on attachment 88276 [details]
Patch with fixes

Clearing flags on attachment: 88276

Committed r82985: <http://trac.webkit.org/changeset/82985>
Comment 6 WebKit Commit Bot 2011-04-05 14:59:31 PDT 
All reviewed patches have been landed.  Closing bug.