Bug 53063

Summary:

[NRWT] Remove TestArgs class

Product:

WebKit

Reporter:

Hayato Ito <hayato>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dpranke, eric, mihaip, ojan, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

53004

Bug Blocks:

51091, 53071

Attachments:

Description	Flags
remove-testargs	none
remove-testargs--review-ready	eric: review+

Hayato Ito

Reported 2011-01-24 21:55:28 PST

It seems we can get rid of TestArgs class in new-run-webkit-tests. TestArgs class is defined in webkitpy/layout_tests/test_types/test_type_base.py. TestArgs has fields of new_baseline, png_path, hash and wdiff, but only a new_baseline (and reset_results, which is wrongly assigned) field is used in actual code. That class is used only in test_type::compare_output() as a parameter, but there TestArgs parameter can be replaced with 'options'.

Attachments
remove-testargs (13.33 KB, patch) 2011-01-24 21:58 PST, Hayato Ito	no flags	Details Formatted Diff Diff
remove-testargs--review-ready (13.25 KB, patch) 2011-02-03 22:09 PST, Hayato Ito	eric: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Hayato Ito

Comment 1 2011-01-24 21:58:49 PST

Created attachment 80019 [details] remove-testargs

Dirk Pranke

Comment 2 2011-01-24 23:22:49 PST

Yup, looks good to me (but I'm not a reviewer).

Dirk Pranke

Comment 3 2011-01-24 23:23:20 PST

adding more people who are reviewers ...

Ojan Vafai

Comment 4 2011-01-25 00:09:29 PST

Comment on attachment 80019 [details] remove-testargs I fully support deleting code.

Hayato Ito

Comment 5 2011-01-25 00:23:05 PST

This patch (A) depends on other patch (B), https://bugs.webkit.org/show_bug.cgi?id=53004, which is under the review. There is no strong relation between (A) and (B), but we should wait for patch (B) to apply this patch (A). I'll set review flag and update this bugzilla entry once patch (B) is landed.

Hayato Ito

Comment 6 2011-02-03 22:09:38 PST

Created attachment 81188 [details] remove-testargs--review-ready

Hayato Ito

Comment 7 2011-02-03 22:10:26 PST

The patch is now ready to be reviewed.

Eric Seidel (no email)

Comment 8 2011-02-03 22:20:54 PST

Comment on attachment 81188 [details] remove-testargs--review-ready OK.

Hayato Ito

Comment 9 2011-02-03 22:26:53 PST

Committed r77606: <http://trac.webkit.org/changeset/77606>

Note You need to log in before you can comment on or make changes to this bug.