Bug 53058

Summary:

Reset the page scale factor on standard frame loads

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	mitz: review+

Description Anders Carlsson 2011-01-24 18:23:51 PST

Reset the page scale factor on standard frame loads

Comment 1 Anders Carlsson 2011-01-24 18:26:19 PST

Created attachment 80005 [details]
Patch

Comment 2 mitz 2011-01-24 18:30:03 PST

Comment on attachment 80005 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=80005&action=review

> Source/WebKit2/UIProcess/WebPageProxy.h:263
> +    void viewScaleFactorDidChange(double scaleFactor);

Can omit “scaleFactor”

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:438
> +        newPageScaleFactor = 1.0;

Should omit “.0”. Also, no need to fetch the value if the above condition holds, only to have it overwritten by 1.

Comment 3 Anders Carlsson 2011-01-24 18:38:18 PST

Committed r76561: <http://trac.webkit.org/changeset/76561>