| Summary: | Remove RenderSlider::inDragMode and use SliderThumbElement::inDragMode instead. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||
| Component: | New Bugs | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||
| Status: | RESOLVED INVALID | ||||||
| Severity: | Normal | CC: | darin | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 44907 | ||||||
| Attachments: |
|
||||||
|
Description
Dimitri Glazkov (Google)
2011-01-24 16:34:29 PST
Created attachment 79989 [details]
Patch
Just cleaning stuff up after the move. Comment on attachment 79989 [details]
Patch
Seems strange to have all this code that is render tree oriented have to go back to the DOM tree for one thing and not the rest. The RenderThemeWin code especially stands out, with all those renderer checks mixed in with one DOM check.
(In reply to comment #3) > (From update of attachment 79989 [details]) > Seems strange to have all this code that is render tree oriented have to go back to the DOM tree for one thing and not the rest. The RenderThemeWin code especially stands out, with all those renderer checks mixed in with one DOM check. I am on the fence with this patch. Perhaps turn this into a helper function on RenderSliderThumb object? I decided that this patch isn't useful. |