Summary: | layoutTestController.counterValueForElementById does not return the correct value | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carol Szabo <carol> | ||||||||
Component: | Tools / Tests | Assignee: | Carol Szabo <carol> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | OS X 10.5 | ||||||||||
Bug Depends on: | 53024 | ||||||||||
Bug Blocks: | 52126 | ||||||||||
Attachments: |
|
Description
Carol Szabo
2011-01-24 12:39:32 PST
Have patch ready, waiting for my patch to 53024 to land as it depends on that. Created attachment 80660 [details]
Proposed Patch
This is my proposed patch. Waiting for my patch to 53024 to be landed before I submit this for review and commit (or else it won't build).
Created attachment 80767 [details]
Proposed Patch
Comment on attachment 80767 [details] Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80767&action=review Feel free to have another committer change commit-queue from - to + if you decide you don’t want to make my suggested minor tweaks. > Source/WebCore/rendering/RenderTreeAsText.cpp:773 > + // The counter renderers should be children of > + // :before or :after pseudo-elements. No reason to break this comment into two lines. > Source/WebCore/rendering/RenderTreeAsText.cpp:780 > + RenderObject* pseudoElement = renderer->beforePseudoElementRenderer(); > + if (pseudoElement) > + writeCounterValuesFromChildren(stream, pseudoElement, isFirstCounter); > + pseudoElement = renderer->afterPseudoElementRenderer(); > + if (pseudoElement) > + writeCounterValuesFromChildren(stream, pseudoElement, isFirstCounter); I suggest putting the local variable definitions into the if statements. Created attachment 80786 [details]
Proposed Patch. Addressed darin's concerns
Comment on attachment 80786 [details]
Proposed Patch. Addressed darin's concerns
r=me
Comment on attachment 80786 [details] Proposed Patch. Addressed darin's concerns Clearing flags on attachment: 80786 Committed r77273: <http://trac.webkit.org/changeset/77273> All reviewed patches have been landed. Closing bug. |