Bug 53030

Summary:

[Qt] Unskip html5lib/runner.html

Product:

WebKit

Reporter:

Robert Hogan <robert>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dominicc, ossy

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

51379

Bug Blocks:

Attachments:

Description	Flags
Remove from Skipped list.	none

Robert Hogan

Reported 2011-01-24 11:32:55 PST

when bug 51379 is resolved

Attachments
Remove from Skipped list. (1.13 KB, patch) 2011-10-24 08:31 PDT, Zoltan Arvai	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dominic Cooney

Comment 1 2011-02-06 18:10:10 PST

After 51379 keygen no longer fails, but entity test fails: --- /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/layout-test-results/html5lib/runner-expected.txt 2011-02-06 17:47:15.689742095 -0800 +++ /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/layout-test-results/html5lib/runner-actual.txt 2011-02-06 17:47:15.689742095 -0800 @@ -315,8 +315,35 @@ resources/html5test-com.dat: PASS -resources/entities01.dat: PASS +resources/entities01.dat: +63 +65 +Test 63 of 67 in resources/entities01.dat failed. Input: +FOO􏿾ZOO +Got: +| <html> +| <head> +| <body> +| "FOO?ZOO" +Expected: +| <html> +| <head> +| <body> +| "FOOï¿½ZOO" + +Test 65 of 67 in resources/entities01.dat failed. Input: +FOO􏿿ZOO +Got: +| <html> +| <head> +| <body> +| "FOO?ZOO" +Expected: +| <html> +| <head> +| <body> +| "FOOï¿½ZOO" resources/entities02.dat: PASS resources/comments01.dat: PASS

Robert Hogan

Comment 2 2011-02-13 04:58:49 PST

Oh God, more Qt UTF8-related foo.

Robert Hogan

Comment 3 2011-02-13 05:28:07 PST

I don't get this locally - linked against both Qt 7.1 stable trunk and Qt 6.X.

Zoltan Arvai

Comment 4 2011-10-24 08:31:47 PDT

Created attachment 112191 [details] Remove from Skipped list. Test passes with current revisions. (Qt 4.8.0-rc1)

Csaba Osztrogonác

Comment 5 2011-10-25 02:34:52 PDT

Comment on attachment 112191 [details] Remove from Skipped list. Clearing flags on attachment: 112191 Committed r98329: <http://trac.webkit.org/changeset/98329>

Csaba Osztrogonác

Comment 6 2011-10-25 02:34:59 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.