Bug 53029

Summary: WebKit2: LayoutTests: The UNIMPLEMENTED warnings in TextCheckerWin should be disabled
Product: WebKit Reporter: Jessie Berlin <jberlin>
Component: WebKit2Assignee: Jessie Berlin <jberlin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, aroben, jberlin, sam
Priority: P2 Keywords: PlatformOnly
Version: 528+ (Nightly build)   
Hardware: All   
OS: Windows 7   
Attachments:
Description Flags
Patch none

Jessie Berlin
Reported 2011-01-24 11:32:20 PST
They are showing up in the output of a lot of layout tests (e.g. plugins/access-after-page-destroyed.html), particularly due to the call in const TextCheckerState& TextChecker::state() { notImplemented(); return textCheckerState; } We should disable the UNIMPLEMENTED warnings in TextCheckerWin.cpp.
Attachments
Patch (deleted)
2011-01-24 11:37 PST, Jessie Berlin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-01-24 11:35:57 PST
This can be done with #define DISABLE_NOT_IMPLEMENTED_WARNINGS 1
Jessie Berlin
Comment 2 2011-01-24 11:37:08 PST
Created attachment 79946 [details] Patch
Jessie Berlin
Comment 3 2011-01-24 13:03:34 PST
Comment on attachment 79946 [details] Patch Committed in r76543 http://trac.webkit.org/changeset/76543
Note You need to log in before you can comment on or make changes to this bug.