Bug 53012

Summary: IndexedDatabase methods should not take arguments of type OptionsObject
Product: WebKit Reporter: Andrei Popescu <andreip>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, hans, japhet, jorlow, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch japhet: review+

Description Andrei Popescu 2011-01-24 08:07:43 PST
IndexedDatabase methods should not take arguments of type OptionsObject
Comment 1 Andrei Popescu 2011-01-24 08:32:39 PST
Created attachment 79925 [details]
Patch
Comment 2 Hans Wennborg 2011-01-24 08:49:34 PST
Looks good as far as I can tell.
Comment 3 WebKit Review Bot 2011-01-24 08:53:06 PST
Attachment 79925 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7531301
Comment 4 Andrei Popescu 2011-01-24 09:05:34 PST
Created attachment 79934 [details]
Patch
Comment 5 Nate Chapin 2011-01-24 09:40:02 PST
Comment on attachment 79934 [details]
Patch

My only complaint is that we're adding yet another converter to V8Binding.cpp, but I don't think that's avoidable.
Comment 6 Hans Wennborg 2011-01-24 09:45:50 PST
Comment on attachment 79934 [details]
Patch

> Source/WebCore/storage/IDBDatabase.cpp:113
> +    if (timeout > std::numeric_limits<unsigned long>::max())

It still feels fishy. It seems to me this condition can never be true?
Comment 7 WebKit Review Bot 2011-01-24 09:59:57 PST
Attachment 79925 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7546312
Comment 8 Jeremy Orlow 2011-01-24 10:50:02 PST
Comment on attachment 79934 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79934&action=review

LGTM

> Source/WebCore/bindings/v8/V8Binding.h:35
> +#include "DOMStringList.h"

Just forward declare here.

>> Source/WebCore/storage/IDBDatabase.cpp:113
>> +    if (timeout > std::numeric_limits<unsigned long>::max())
> 
> It still feels fishy. It seems to me this condition can never be true?

It really doesn't matter either way...
Comment 9 Andrei Popescu 2011-01-24 10:55:07 PST
(In reply to comment #8)
> (From update of attachment 79934 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79934&action=review
> 
> LGTM
> 
> > Source/WebCore/bindings/v8/V8Binding.h:35
> > +#include "DOMStringList.h"
> 
> Just forward declare here.
> 

Done.

> >> Source/WebCore/storage/IDBDatabase.cpp:113
> >> +    if (timeout > std::numeric_limits<unsigned long>::max())
> > 
> > It still feels fishy. It seems to me this condition can never be true?
> 
> It really doesn't matter either way...

I will remove that check then and land.

Thanks all for the reviews!
Comment 10 Andrei Popescu 2011-01-24 11:02:05 PST
Committed r76531: <http://trac.webkit.org/changeset/76531>